Skip to content

Initial version of the inline powerbox#1398

Open
jparyani wants to merge 2 commits into
sandstorm-io:masterfrom
jparyani:inline-powerbox
Open

Initial version of the inline powerbox#1398
jparyani wants to merge 2 commits into
sandstorm-io:masterfrom
jparyani:inline-powerbox

Conversation

@jparyani

Copy link
Copy Markdown
Collaborator

It's still a bit rough around the edges, but the basic functionality
works.

It's still a bit rough around the edges, but the basic functionality
works.
Comment thread tests/apps/powerbox.js

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Faling/Failing/

@ocdtrekkie ocdtrekkie added the app-platform App/Sandstorm integration features label Jan 16, 2020
@ocdtrekkie

Copy link
Copy Markdown
Collaborator

What is this PR in comparison to Sandstorm today, @zenhack? Should this be closed?

@zenhack

zenhack commented Feb 9, 2020

Copy link
Copy Markdown
Collaborator

It looks like this is a slightly different feature/design than what sandstorm currently has; if I'm reading the code correctly it shows an input just below the bottom of the grain frame, instead of a modal dialog floating over it. What I don't know is what the intent was here -- were folks expecting to have both UIs for some reason, or is this just obsolete? Is there a design doc somewhere?

@kentonv, any thoughts?

@kentonv

kentonv commented Feb 15, 2020

Copy link
Copy Markdown
Member

The "inline powerbox" refers to the "autocomplete style" powerbox UI described in the roadmap.

I do think this style of powerbox is important in the long term. Many kinds of everyday interactions -- such as selecting recipients of an e-mail -- become cumbersome with a full powerbox, but could be made to feel almost normal using the inline powerbox, without sacrificing security.

However, implementing the inline powerbox is pretty hairy, since it requires communication between the app and the shell to capture keystrokes and decide where to render the overlay. I think we should focus on lower-hanging fruit for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app-platform App/Sandstorm integration features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants